Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

benchmark: replace deprecated and eliminate var in buffer-from.js #26585

Closed
wants to merge 1 commit into from
Closed

benchmark: replace deprecated and eliminate var in buffer-from.js #26585

wants to merge 1 commit into from

Conversation

gengjiawen
Copy link
Member

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added benchmark Issues and PRs related to the benchmark subsystem. buffer Issues and PRs related to the buffer subsystem. labels Mar 11, 2019
@Trott
Copy link
Member

Trott commented Mar 11, 2019 •
edited
Loading

A possible problem with this change: Benchmarks are used to compare multiple versions of node to track performance. Since let in a for loop incurs a performance penalty in Node.js 6 and earlier, this will artificially show a performance increase in more recent versions of Node.js that is actually a performance increase in the use of let in a for loop and not a performance increase due to improvements in Buffer.from().

@Trott
Copy link
Member

Trott commented Mar 11, 2019

A possible problem with this change: Benchmarks are used to compare multiple versions of node to track performance. Since let in a for loop incurs a performance penalty in Node.js 6 and earlier, this will artificially show a performance increase in more recent versions of Node.js that is actually a performance increase in the use of let in a for loop and not a performance increase due to improvements in Buffer.from().

(On the other hand, I don't know that anyone is actually benchmarking 6 much these days. Although it does continue to show up in the charts at https://benchmarking.nodejs.org/ so maybe?)

@Trott
Copy link
Member

Trott commented Mar 11, 2019

^^^^^ Not blocking from me, but something for reviewers to consider.

@danbev
Copy link
Contributor

danbev commented Mar 12, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/21449/

@gengjiawen gengjiawen mentioned this pull request Mar 21, 2019
Closed
2 tasks
@danbev
Copy link
Contributor

danbev commented Mar 21, 2019 •
edited
Loading

Re-run of failing node-test-commit-arm (✔️)

@danbev
Copy link
Contributor

danbev commented Mar 21, 2019

Landed in 11f8024.

@danbev danbev closed this Mar 21, 2019
danbev pushed a commit that referenced this pull request Mar 21, 2019
@gengjiawen @danbev
benchmark: replace deprecated and eliminate var in buffer-from.js
11f8024 
PR-URL: #26585
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos pushed a commit to targos/node that referenced this pull request Mar 27, 2019
@gengjiawen @targos
benchmark: replace deprecated and eliminate var in buffer-from.js
ce9ccb7 
PR-URL: nodejs#26585
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos pushed a commit that referenced this pull request Mar 27, 2019
@gengjiawen @targos
benchmark: replace deprecated and eliminate var in buffer-from.js
3ab438a 
PR-URL: #26585
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@targos targos mentioned this pull request Mar 27, 2019
Merged
BethGriggs pushed a commit that referenced this pull request Apr 17, 2019
@gengjiawen @BethGriggs
benchmark: replace deprecated and eliminate var in buffer-from.js
8916dd5 
PR-URL: #26585
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@BethGriggs BethGriggs mentioned this pull request May 1, 2019
Merged
MylesBorins pushed a commit that referenced this pull request May 16, 2019
@gengjiawen @MylesBorins
benchmark: replace deprecated and eliminate var in buffer-from.js
a8cbe0e 
PR-URL: #26585
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
This was referenced May 29, 2019
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau richardlau approved these changes

@addaleax addaleax addaleax approved these changes

@danbev danbev danbev approved these changes

Assignees
No one assigned
Labels
benchmark Issues and PRs related to the benchmark subsystem. buffer Issues and PRs related to the buffer subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@gengjiawen @Trott @danbev @addaleax @richardlau @nodejs-github-bot